New imagery view for disparity map based measurement#8333
Merged
Conversation
…ew provider and scaffolding for a new view to hold the tool
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8333 +/- ##
==========================================
+ Coverage 55.67% 56.77% +1.09%
==========================================
Files 728 728
Lines 29719 29732 +13
Branches 2816 2817 +1
==========================================
+ Hits 16545 16879 +334
+ Misses 12845 12523 -322
- Partials 329 330 +1
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
- New .scss file measuring-tool.scss. - Markup added and smoke-tested. - Added new property called `isScaling` that controls verbiage contextually: - false if the user is measuring rover to point A. - true if the user measuring point A to B - Minor refinement to CSS for Notebook.
- New markup
…a/openmct into feature-imagery-disparty-map
davetsay
reviewed
Jun 22, 2026
davetsay
left a comment
davetsay
left a comment
Contributor
There was a problem hiding this comment.
I put two comments/questions on the PR but it looks good.
| > * + * { | ||
| margin-top: $interiorMargin; | ||
| } | ||
| gap: $interiorMargin; |
| }, | ||
| template: | ||
| '<imagery-view :focused-image-timestamp="focusedImageTimestamp" @update:focusedImageTimestamp="value => focusedImageTimestamp = value" ref="ImageryContainer"></imagery-view>' | ||
| '<imagery-view :focused-image-timestamp="focusedImageTimestamp" @update:focusedImageTimestamp="value => focusedImageTimestamp = value" @relatedTelemetryIsAvailable="informListenersThatRelatedTelemetryIsAvailable" ref="ImageryContainer"></imagery-view>' |
Contributor
There was a problem hiding this comment.
should work fine but i think Vue naming convention is @related-telemetry-is-available="informListenersThatRelatedTelemetryIsAvailable"
davetsay
pushed a commit
that referenced
this pull request
Jun 23, 2026
* Adds a new right-click menu item to view imagery tools. Adds a new view provider and scaffolding for a new view to hold the tool * Markup and CSS for Imagery Measuring Tool - New .scss file measuring-tool.scss. - Markup added and smoke-tested. - Added new property called `isScaling` that controls verbiage contextually: - false if the user is measuring rover to point A. - true if the user measuring point A to B - Minor refinement to CSS for Notebook. * Markup and CSS for Imagery Measuring Tool - New markup * Remove viper specific code * Refactored view context object. Emit event when related telemetry is available * Tweak colors * Expose spacecraft Z * Fixed failing tests * Fix lint error --------- Co-authored-by: Shefali Joshi <simplyrender@gmail.com> Co-authored-by: Charles Hacskaylo <charlesh88@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes VIPEROMCT-565
Describe your changes:
AH
getViewContext()has got confused. It is NOT for exposing Vue contexts :) We don't want to expose Vue internals via our API.All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist