[Core] Resolve code FIXMEs in Export and Plot models#8334
Open
gajjararyan wants to merge 1 commit into
Open
Conversation
- Encapsulated saveAs method as a private field in ExportAsJSONAction - Updated ExportAsJSONActionSpec to spy on JSONExportService instead of saveAs - Removed unused and obsolete id() method in Plot configuration Model.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
This is a small code cleanup PR that resolves two outstanding
FIXMEcomments in the codebase:saveAsmethod as a private field (#saveAs) and updated the tests inExportAsJSONActionSpec.jsto properly spy on the underlyingJSONExportServiceinstead.id()method which was erroneously marked with a FIXME, as derived models properly use thethis.idproperty directly.All Submissions:
Author Checklist