Convert Vec<T> to Box<[T]> - #195
Merged
Merged
Conversation
Kronos3
force-pushed
the
convert-vec-to-slice-box
branch
from
September 4, 2026 00:53
49b3b50 to
27a97ab
Compare
CoreMark Benchmark ResultsCurrent Score: 239.292 |
Code Coverage ReportCurrent Coverage: 95.46% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally wrote
Vec<T>to storelen: u32andcapacity: u32because for 64-bit this would fix in two words. This was nasty and not correct and required a lot ofas u32casts...We only need to store
lenduring the construction of the module/section. I converted stored members to useBox<[T]>which is a fat pointer of two words already but cannot increase in length. This does not make in size on 64-bit but decreases size on 32-bit from12bytes to8bytes.