sibling-count#28
Open
CodingRule wants to merge 1 commit intonasa:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
sibling-countoption toterra-paginationso consumers can control how many page buttons show on each side of the current page.What changed
sibling-countproperty/attribute toterra-pagination(default is1)current,total, andsibling-countdata-pagedocs/pages/components/pagination.mdwith:sibling-countWhy
Pagination worked well for the default case, but there was no way to control page window size for larger datasets. This adds that flexibility while keeping existing defaults intact.
Backward compatibility
No breaking changes.
If
sibling-countis not set, behavior stays the same as before.Testing
npx web-test-runner --group paginationnpm run build