Skip to content

fix: UI language reverts to English after a second save in Settings #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nashsu merged 1 commit into from
May 1, 2026
Merged

fix: UI language reverts to English after a second save in Settings #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/settings/settings-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,15 @@ export function SettingsView() {
)

// Resync draft from store if it changes out-of-band (e.g. project switch).
// IMPORTANT: keep the current draft.uiLanguage instead of re-reading
// `i18n.language`. handleSave calls multiple zustand setters before it
// calls `i18n.changeLanguage` at the end, and each setter triggers this
// effect mid-save — which used to clobber the user's pending language
// pick with the still-stale `i18n.language`. The next save would then
// see draft.uiLanguage out of sync with i18n.language and silently
// revert the UI to the previous language.
useEffect(() => {
setDraftState(
setDraftState((prev) =>
initialDraft(
llmConfig,
searchApiConfig,
Expand All @@ -161,7 +168,7 @@ export function SettingsView() {
outputLanguage,
proxyConfig,
maxHistoryMessages,
i18n.language,
prev.uiLanguage,
),
)
}, [
Expand Down
Loading