[codex] Fix Claude CLI spawn on Windows#107
Merged
nashsu merged 1 commit intonashsu:mainfrom May 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Claude Code CLI provider on Windows when Settings detects a local
claudeinstall but chat fails withClaude Code CLI not found.Root Cause
The Settings health check resolved the CLI through
which::which("claude"), but the chat transport spawned a bareCommand::new("claude"). On Windows, the npm install usually exposesclaude.cmd/claude.ps1shims and a realclaude.exe; Rust/Tauri process spawning does not behave like PowerShell command resolution, so detection could pass while chat spawn failed.Changes
find_claude_command()helper for Claude CLI resolution.claude.cmdandclaude.exeon Windows, then fall back toclaudefor other platforms.Validation
rustfmt --edition 2021 --check src\commands\claude_cli.rspasses.cargo check --quietcould not complete locally because the installed toolchain isrustc 1.90.0, whilelancedb/lancedependencies requirerustc 1.91.0.Closes #106.
Related: #86.