Fix/order

[thang-ngquoc]

No description provided.

[bitdive-review]

BitDive Runtime Review - PR #1598

PR: #1598
Branch: fix/order -> main
Method: BitDive runtime trace comparison + direct HTTP verification + targeted code inspection
Verdict: APPROVE WITH NOTES
Confidence: High for the checkout fix and stable flows; merge blocked by Liquibase checksum issue on payment seed changesets

Summary

The PR titular fix is confirmed at runtime: checkout POST changed from 500 (HttpMessageConversionException deserializing ProductCheckoutListVm) to 200 with a persisted checkout entity (totalAmount=$799.0). Five stable flows were re-checked with before/after trace pairs and showed no structural regressions. CSRF disable is a runtime no-op for Bearer-authenticated API paths tested here.

Fix before merge: payment Liquibase changesets modified in place (is_enabled -> enabled) without checksum reconciliation — production deploy risk.

Runtime Verification Matrix

Area	Result	Behavior Δ	Meaning	Evidence
Checkout create	Fixed	HTTP 500→200 · errors 6→0 · CheckoutRepository.save added · ~5.8s→~1.3s	Titular Jackson/deserialization bug fixed	before / after
Customer profile	Stable	zero contract drift (200 · 3 steps)	Authenticated read path unchanged	before / after
Payment providers	Stable	zero structural drift (200 · 11 steps)	Seed column rename works at runtime	before / after
Order my-orders	Stable	200 · JVM lambda identity only	Post-migration order list healthy	before / after
Product actuator health	Changed	HTTP 500→200 · health endpoint exposed	Intentional actuator config change	HTTP verified
Cart flows	Stable	200 · structural contract stable · qty drift from test sequencing	No regression in cart service path	items before / items after

How to read BitDive evidence

Behavior Δ (matrix) and the red/green diff Behavior contract inside each Change are the contract summary.
Evidence links open the full BitDive share: call tree · SQL · writes · downstream · first divergence.

• Trace pair — full trees compared
• HTTP only — status/body; no JVM tree
• Code only — inspection only

Review scope and validation coverage

order
  -> CheckoutController.createCheckout()     [titular fix]
  -> ProductCheckoutListVm @NoArgsConstructor
cart / customer
  -> SecurityConfig CSRF + CORS             [verified stable for Bearer API paths]
payment
  -> seed SQL column rename is_enabled->enabled
product
  -> actuator exposure health,metrics,prometheus

Behavior	Scenario	Evidence	Status
Checkout deserialization fix	POST checkout	Trace pair	Confirmed
Customer profile	GET profile	Trace pair	Confirmed
Payment providers list	GET providers	Trace pair	Confirmed
Order list	GET my-orders	Trace pair	Confirmed
Product actuator health	GET actuator/health	HTTP only	Confirmed
Liquibase payment checksum	deploy migration	Code inspection	Merge blocker

Change #1 - checkout deserialization fix

Add @NoArgsConstructor / @AllArgsConstructor to ProductCheckoutListVm so Jackson can deserialize product payload during checkout.

Behavior contract

# POST checkout — runtime contract
- HTTP 500 HttpMessageConversionException
+ HTTP 200 CheckoutVm (id persisted, totalAmount=$799.0)
- 6 error nodes, 3 retry+fallback cycles
+ 0 errors, single successful ProductService call
+ SQL WRITE CheckoutRepository.save()
# first divergence: CheckoutService.createCheckout()

Trace evidence

Phase	HTTP	Steps	Notes
Before	500	14	Type definition error for ProductCheckoutListVm
After	200	31	Checkout persisted, product deserialized (iPhone 15, $799)

Key trace delta

• Removed repeated failed ProductService.getProductInfomation() calls and fallback handlers
• Added successful deserialization and CheckoutRepository.save() write on head

Change #2 - stable service paths

Cart, customer, payment, and order list flows stayed structurally stable. Cart quantity drift came from sequential test mutations across base/head phases, not from a contract break.

Behavior contract

# stable flows — runtime contract
  HTTP 200 on customer profile, payment providers, order list (both sides)
  cart add/list: 200 both sides; quantity differs from test sequencing only

Follow-Ups

Type	Item	Why it matters
Merge blocker	Payment Liquibase checksum on modified changesets (hoanglam:paypal, hieunc:cod)	Production deploy can fail without runOnChange / new migration
Non-blocking	Pre-existing MediaService.getMediaVmMap ClassCastException	Present on base and head; not introduced by this PR
Non-blocking	CSRF disable no-op for Bearer API	Browser cookie sessions may differ; API paths tested here unchanged

Recommendation

Approve with notes. Runtime evidence supports the checkout fix and shows no regressions on exercised paths. Resolve the payment Liquibase checksum blocker before merge.