Fixed clouds#279
Open
aditya-sengupta wants to merge 16 commits into
Open
Conversation
Contributor
Author
|
I re-pulled |
…e top of climate for fixed
Contributor
Author
|
This works (preserves program flow for cloudless and self-consistent cases + works as I'd expect for fixed) building off commit 5bca789. Currently unable to test with the new version of dev as I don't have the 2121 CK tables and not sure where to find them |
Contributor
Author
|
Oops, restored the earlier version. There may also be changes like this within justdoit.py that updated between dev two months ago and now, not sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(No longer closes #278, I need to do that separately) This adds a fixed-cloud mode to PICASO climate calculations. Users can specify a cloud OPD, single-scattering albedo, and asymmetry, and these will be added as fixed opacity sources independent of the current temperature. The run will have the same program flow as a cloudless run and will solve for the temperature structure corresponding to the extra opacity.