Nimbus Integration#406
Open
James-Mang wants to merge 9 commits into
Open
Conversation
This commit standardizes the import aliases used in all documentation notebooks to: - picaso.justdoit as jdi - picaso.justplotit as jpi - virga.justdoit as vdi - virga.justplotit as vpi All usages of previous aliases (e.g., pj, vj, picplt, cldplt, vjdi, vjpi) have been updated to match the new standards. In cases of name collisions with external libraries (specifically pandexo), the external library aliases have been renamed (e.g., to panjdi, panjpi) to maintain the picaso/virga standards. Import statements have also been standardized to the 'import module as alias' format and consolidated at the top of the files/cells. Co-authored-by: James-Mang <33335954+James-Mang@users.noreply.github.com>
Updated all documentation notebooks to use the 'from picaso import justdoit as jdi' style as requested. This covers: - picaso.justdoit as jdi - picaso.justplotit as jpi - virga.justdoit as vdi - virga.justplotit as vpi Also standardized pandexo imports in relevant notebooks for consistency. Fixed a regression in FAQs.py where a documentation link anchor was incorrectly modified. Removed temporary standardization scripts. Co-authored-by: James-Mang <33335954+James-Mang@users.noreply.github.com>
…040113605783200965 Standardize notebook import aliases
…rsion flexible Co-authored-by: Copilot <copilot@github.com>
nimbus integration
Owner
|
@James-Mang can you
Then question regarding release of this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial integration of Nimbus into PICASO for self-consistent cloud modeling. Provides the option to do virga or nimbus clouds. Not fully tested for a wide range of objects but does function (though it takes longer of course) but is useable if others are interested to have this added to the functionality within the dev branch now.
I also made a minor change to the numpy trapezoid syntax. It's really annoying to have the difference between numpy <2.0 and >2.0 be different when other package dependencies haven't upgraded to be compatible with numpy >=2.0 yet.
It also looks like there's some bookkeeping stuff that I cherrypicked over to master before even pushing to dev because of the other commits that were there so hopefully those don't cause conflicts.