Skip to content

update interpreting results section of Rec chapter.#179

Merged
claire-simpson merged 3 commits intonatcap:release/3.16.0from
davemfish:feature/REC-1893-userday-metrics
May 15, 2025
Merged

update interpreting results section of Rec chapter.#179
claire-simpson merged 3 commits intonatcap:release/3.16.0from
davemfish:feature/REC-1893-userday-metrics

Conversation

@davemfish
Copy link
Copy Markdown
Contributor

This goes along with the changes in natcap/invest#1918, but does not require updating the invest dependency.

Copy link
Copy Markdown
Contributor

@claire-simpson claire-simpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davemfish - just requested a couple tiny changes!

Comment thread source/en/recreation.rst Outdated
+ **avg_pr_UD**: average of pr_PUD and pr_TUD. This variable is logit-transformed and then used as the response variable in the regression model.
+ **avg_pr_UD**: average of pr_TUD and pr_TUD. This variable is logit-transformed and then used as the response variable in the regression model.

+ If Compute Regression is selected, one field for each predictor given in the Predictor Table. The values of those fields are the metric calculated per response feature (:ref:`rec-data-needs`: Predictor Table).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Compute Regression is selected, one field for each predictor given in the Predictor Table.

This sentence is incomplete - should this be "one field for each predictor is given in the Predictor Table"?

Comment thread source/en/recreation.rst Outdated
+ **pr_TUD**: the proportion of the sum of TUD_YR_AVG across all features

+ **avg_pr_UD**: average of pr_PUD and pr_TUD. This variable is logit-transformed and then used as the response variable in the regression model.
+ **avg_pr_UD**: average of pr_TUD and pr_TUD. This variable is logit-transformed and then used as the response variable in the regression model.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ **avg_pr_UD**: average of pr_TUD and pr_TUD. This variable is logit-transformed and then used as the response variable in the regression model.
+ **avg_pr_UD**: average of pr_PUD and pr_TUD. This variable is logit-transformed and then used as the response variable in the regression model.

@davemfish
Copy link
Copy Markdown
Contributor Author

@claire-simpson Thanks for the edits, I fixed these cases.

@davemfish davemfish requested a review from claire-simpson May 15, 2025 12:59
Copy link
Copy Markdown
Contributor

@claire-simpson claire-simpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@claire-simpson claire-simpson merged commit 4d2b61a into natcap:release/3.16.0 May 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants