Skip to content

Urban Flood Risk: Rename Runoff_retention.tif#1914

Merged
davemfish merged 1 commit intonatcap:release/3.16.0from
megannissel:feature/1837-ufr-rename-output
May 9, 2025
Merged

Urban Flood Risk: Rename Runoff_retention.tif#1914
davemfish merged 1 commit intonatcap:release/3.16.0from
megannissel:feature/1837-ufr-rename-output

Conversation

@megannissel
Copy link
Copy Markdown
Contributor

@megannissel megannissel commented May 8, 2025

Description

Fixes #1837

Updated the name of the output raster Runoff_retention.tif to Runoff_retention_index.tif, to help clarify the difference between it and Runoff_retention_m3.tif.

User's Guide PR: natcap/invest.users-guide#177

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
    Tested the Workbench UI (if relevant)

@megannissel megannissel marked this pull request as ready for review May 8, 2025 18:54
@megannissel
Copy link
Copy Markdown
Contributor Author

megannissel commented May 8, 2025

Test failure appears to be HRA-related:

tests/test_hra.py::HRAModelTests::test_model - ValueError: Vector geometry type must be Polygon or MultiPolygon

I believe this is related to the latest Pygeoprocessing release, and is addressed by #1882

@megannissel megannissel changed the base branch from main to release/3.16.0 May 9, 2025 15:37
@megannissel megannissel requested a review from davemfish May 9, 2025 16:01
@davemfish davemfish merged commit 0799b05 into natcap:release/3.16.0 May 9, 2025
23 of 39 checks passed
@megannissel megannissel deleted the feature/1837-ufr-rename-output branch May 13, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename UFR "Runoff_retention.tif" output

2 participants