Consolidate wheel and sdist build jobs#2541
Open
emlys wants to merge 5 commits intonatcap:mainfrom
Open
Conversation
dcdenu4
requested changes
May 5, 2026
Comment on lines
+163
to
+164
| name: Source distribution for ${{ matrix.os }} ${{ matrix.python-version }} | ||
| path: dist/*.tar.gz |
Member
There was a problem hiding this comment.
Does this allow us to upload multiple source distributions without having to worry if they're being overwritten? Re: a comment we had below
# Only upload sdist in one of the matrix cases so we don't
# overwrite artifacts or have duplicates (mac/windows sdists have
# different extensions)
Member
Author
There was a problem hiding this comment.
Oh, good point. So we've been uploading just one sdist to the GCP bucket, but all the sdists as github actions artifacts. Sdists should work the same on any OS or python version, so I think we can drop the extra artifact uploads as well.
Member
Author
There was a problem hiding this comment.
I changed this to upload only one sdist to GCP and github.
Member
Author
There was a problem hiding this comment.
This simplifies the release workflow a little, too, since we don't have to choose an arbitrary one of multiple sdist artifacts to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2514
This PR removes the separate sdist build job and consolidates it into the test job, where we already build and upload a wheel. The failing puppeteer test seems unrelated.
Checklist