Add support for SLURM 24.11.0+ API changes#96
Open
stevenweaver wants to merge 1 commit intonatefoo:mainfrom
Open
Add support for SLURM 24.11.0+ API changes#96stevenweaver wants to merge 1 commit intonatefoo:mainfrom
stevenweaver wants to merge 1 commit intonatefoo:mainfrom
Conversation
Replace deprecated slurm_addto_step_list() with manual step list construction for SLURM 24.11.0+, which removed this helper function. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Are you sure it was removed? It still appears in the dev version, the most I can find is that the signature changed slightly in SchedMD/slurm@7db34cd. |
Owner
|
I think we just want to remove the version gating for the definition in |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slurm_addto_step_list()helper functionslurm_selected_step_tfor newer SLURM versionsChanges
slurm_drmaa/job.cinslurmdrmaa_job_on_missing()functionSLURM_VERSION_NUM(24,11,0)Test plan
🤖 Generated with Claude Code