Skip to content

Add support for SLURM 24.11.0+ API changes#96

Open
stevenweaver wants to merge 1 commit intonatefoo:mainfrom
stevenweaver:slurm-24-11-support
Open

Add support for SLURM 24.11.0+ API changes#96
stevenweaver wants to merge 1 commit intonatefoo:mainfrom
stevenweaver:slurm-24-11-support

Conversation

@stevenweaver
Copy link

Summary

  • Adds compatibility for SLURM 24.11.0+ which removed the slurm_addto_step_list() helper function
  • Manually constructs step list entries using slurm_selected_step_t for newer SLURM versions
  • Maintains backward compatibility with older SLURM versions through preprocessor directives

Changes

  • Modified slurm_drmaa/job.c in slurmdrmaa_job_on_missing() function
  • Added version check for SLURM_VERSION_NUM(24,11,0)
  • Replaces removed helper with explicit step list construction

Test plan

  • Verify compilation with SLURM 24.11.0+
  • Verify compilation with SLURM versions < 24.11.0
  • Test job accounting queries with both versions

🤖 Generated with Claude Code

Replace deprecated slurm_addto_step_list() with manual step list construction for SLURM 24.11.0+, which removed this helper function.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@natefoo
Copy link
Owner

natefoo commented Dec 12, 2025

Are you sure it was removed? It still appears in the dev version, the most I can find is that the signature changed slightly in SchedMD/slurm@7db34cd.

@natefoo
Copy link
Owner

natefoo commented Dec 12, 2025

I think we just want to remove the version gating for the definition in slurm_missing.h, more in #95

@natefoo natefoo mentioned this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants