Skip to content

fix: auto-detect Linux root for Chromium --no-sandbox in shoot.mjs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Noxy229 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −1
Open

fix: auto-detect Linux root for Chromium --no-sandbox in shoot.mjs #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions plugins/nateherk-design/skills/scrollcraft/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,24 @@ Dated notes on what changed in the skill and which build's finding drove it.
Builds live in `OtherWorlds/Ultimate Websites/builds/`; each carries a
`BUILD-REPORT.md`.

## 2026-08-26: Linux/root Chromium fix in shoot.mjs

Driven by a first Linux build (Debian 12, Node 24) where `chromium.launch()`
crashed immediately when running as root without `--no-sandbox`.

**Scripts, `scripts/shoot.mjs`**

- `launch()` now auto-detects root (`process.getuid() === 0`) and passes
`["--no-sandbox", "--disable-setuid-sandbox"]` automatically. Opt-in
override via `SCROLLCRAFT_NO_SANDBOX=1` for non-root setups that still need
it. Safe on a private server; never set on shared machines.
- No behaviour change on macOS or Windows (no `getuid`).

**Finding that drove it:** shoot.mjs exited immediately with a Chromium crash
log on Debian 12 as root. The harness never opened a page. Adding `--no-sandbox`
resolved it. Auto-detection on uid=0 means Linux root builds work out of the box
without any env override.

## 2026-08-23: iOS clip priming hardened; real-device diagnostic added

Driven by a build whose hero clip sat frozen on the owner's actual iPhone
Expand Down
9 changes: 8 additions & 1 deletion plugins/nateherk-design/skills/scrollcraft/scripts/shoot.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,14 @@ if (!CHROME) {

fs.mkdirSync(OUT, { recursive: true });

const browser = await chromium.launch({ executablePath: CHROME, headless: true });
// Linux/root: set SCROLLCRAFT_NO_SANDBOX=1 if Chromium refuses to start.
// This is safe on a private server; never set it on a shared/production machine.
const noSandbox = process.env.SCROLLCRAFT_NO_SANDBOX === "1" || process.getuid?.() === 0;
const browser = await chromium.launch({
executablePath: CHROME,
headless: true,
args: noSandbox ? ["--no-sandbox", "--disable-setuid-sandbox"] : [],
});
const page = await browser.newPage({
viewport: { width: W, height: H },
deviceScaleFactor: 2,
Expand Down