Skip to content

feat(scanner): add real-time scan progress reporting - #17

Open
mikedamoiseau wants to merge 1 commit into
nateherkai:mainfrom
mikedamoiseau:feat/scan-progress
Open

feat(scanner): add real-time scan progress reporting#17
mikedamoiseau wants to merge 1 commit into
nateherkai:mainfrom
mikedamoiseau:feat/scan-progress

Conversation

@mikedamoiseau

Copy link
Copy Markdown

Summary

  • Add a progress callback parameter to scan_dir() so callers get notified after each file is processed
  • Wire it up in cli.py to show a live scanning X/Y files (N msgs, M tools) counter during token-dashboard scan
  • Remove a stale comment in the scanner loop

Demo

Token Dashboard: scanning…
  scanning 1065/1657 files  (83505 msgs, 47148 tools)

Test plan

  • Run python3 -m unittest discover tests — all 68 tests pass
  • Run python3 cli.py scan — verify live progress counter appears and final summary prints correctly
  • Run python3 cli.py scan a second time (incremental) — verify counter skips up-to-date files

Show a live counter of files scanned and messages/tools found during
`token-dashboard scan`.  The new `progress` callback on `scan_dir()`
lets callers render incremental updates without polling.
muckybuzzwoo added a commit to muckybuzzwoo/token-dashboard that referenced this pull request May 22, 2026
…kai#19

- nateherkai#18 (perf scanner) and nateherkai#19 (attributionSkill + split skills view)
  added to the Integrated upstream PRs table with adaptation notes.
- nateherkai#17 added to Deliberately skipped with the reason: PR nateherkai#17's progress
  callback signature (scanned, total, totals) is strictly less
  informative than this fork's (index, total, path, totals) from PR #2,
  so integrating it would degrade the CLI progress printer.
- Differences from upstream rewritten: clarifies the new Skills &
  Commands route's split between "You ran" (slash commands via
  attribution_skill) and "Claude invoked" (real Skill tool calls),
  and notes that the two sources are de-duplicated against each
  other so the same slash command never inflates both columns.
- Scanner performance section updated to reflect the post-nateherkai#18
  measurement (~7.5s full rescan of ~600 files / 60k+ messages).
@muckybuzzwoo

Copy link
Copy Markdown

Hey Mike:
the fork at https://github.com/muckybuzzwoo/token-dashboard already had a progress callback from PR #2 with a slightly richer signature (index, total, path, totals), so I didn't pull #17 in. Yours has a cleaner CLI message format though — if you ever want to extend yours to a richer signature it'd compose nicely with the existing scan_dir callback contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants