-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FFMPEG, rework onSynth in espeak to finish correctly #348
Remove FFMPEG, rework onSynth in espeak to finish correctly #348
Conversation
yay tested on linux locally. going to merge.... |
Hi Will, this is now playing the full sentence! :) |
Yay! But say again? Second sentence isn’t working? I think you’re saying if you do two say calls only first one is read ..so merged but can’t do a release just yet! |
Actually only the second one is read. |
Ok. I at least know what this is. I just fixed the same problem in the avsynth engine. @cclauss we need to add a test to our test suite of two say() calls then runandwait - otherwise this gets missed |
Glad to hear it's not too tricky. Thanks for the prompt replies.
…On Mon, Oct 28, 2024 at 6:06 AM will wade ***@***.***> wrote:
Actually only the second one is read.
Ok. I at least know what this is. I just fixed the same problem in the
avsynth engine.
@cclauss <https://github.com/cclauss> we need to add a test to our test
suite of two say() calls then runandwait - otherwise this gets missed
—
Reply to this email directly, view it on GitHub
<#348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMEU37C3A3SU5FZ3SUP62ZDZ5XA45AVCNFSM6AAAAABQTDVUOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGYZDQOBTHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Like us on Facebook: www.facebook.com/SaberAstronautics
<http://www.facebook.com/SaberAstronautics>
*Confidentiality*****
This
email message and its attachments are subject to copyright and may contain
privileged and confidential information intended for the recipient only. If
this email is accidentally received by any person other than the recipient
please return it to Saber Astronautics. immediately. If you are not the
intended recipient please do not review, re-transmit or disseminate this
message or any attachments. The views expressed in this email are those of
the individual sender and may not reflect the views of Saber Astronautics.
Saber Astronautics does not accept legal responsibility for the contents
of this message or any attachments. Viruses causing any loss or damage are
not Saber Astronautics responsibility.
|
pyttsx3
on Ubuntu #324I stupidly did this on my master branch. Here is the same PR on a branch
Please consider Draft until someone confirms works as expected in Linux (Works on WIndows and MacOS)
Test with
You should hear how it reads ie whole string ending "with it" . On current released versions it will stop at "what to do"
before: would silently fail. Now saves to test.wav
NB: Im aware if you have characters in your text that arent letters (eg ;,!') it will stop at that string. Figuring out a workaround to this to not leave to the user.. or even better a fix for thatNow fixed