Fix a bugs with jetcoeffs! and ODEFunction#348
Merged
Conversation
I'm not quite sure what caused this but if I had to guess I'd say that earlier `f` was a regular function, but now it is an ODEFunction. Or maybe ODEFunction subtyped function, if that was possible? Either way, this part was broken but doing `f.f` should fix it. Found the culprit: SciML/SciMLBase.jl@2e306e3#diff-f72b8c6a35994ffc7188a3982d1ed322e6363246283292a4bceef0c402795edfL590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently
ODEFunctionwas a subtype ofFunctionearlier, but isn't anymore:SciML/SciMLBase.jl@2e306e3#diff-f72b8c6a35994ffc7188a3982d1ed322e6363246283292a4bceef0c402795edfL590
This breaks our usage of TaylorIntegration.jl's
jetcoeffs!which assumes that the first argument is aFunction. This PR fixes this.