Skip to content

Fix errors of Aqua.jl and JET.jl #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanaelbosch merged 3 commits into from
Nov 29, 2025
Merged

Fix errors of Aqua.jl and JET.jl #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
220fc2b
Add explicit import to fix an error from Aqua.jl
nathanaelbosch Nov 29, 2025
5bd9a7c
Rename variable to fix an error from JET.jl
nathanaelbosch Nov 29, 2025
06769b1
Fix another JET.jl test
nathanaelbosch Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ProbNumDiffEq.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ using DocStringExtensions
using Reexport
@reexport using DiffEqBase
import SciMLBase
import SciMLBase: WOperator # just to fix an Aqua.jl test
import SciMLBase: interpret_vars, getsyms, remake
using OrdinaryDiffEqCore,
OrdinaryDiffEqDifferentiation,
Expand Down
3 changes: 1 addition & 2 deletions src/callbacks/manifoldupdate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ function manifoldupdate!(cache, residualf; maxiters=100, ϵ₁=1e-25, ϵ₂=1e-1
m_tmp, C_tmp = mean(x_tmp), cov(x_tmp)

m_i = copy(m)
local m_i_new, C_i_new
for i in 1:maxiters
u_i = mul!(tmp, SolProj, m_i)

Expand All @@ -40,7 +39,7 @@ function manifoldupdate!(cache, residualf; maxiters=100, ϵ₁=1e-25, ϵ₂=1e-1
m_i = m_i_new
end

copy!(cache.x, Gaussian(m_i_new, C_i_new))
copy!(cache.x, Gaussian(m_tmp, C_tmp))

return nothing
end
Expand Down
2 changes: 1 addition & 1 deletion src/priors/common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ Samples from the Gauss-Markov process on the given time grid.

See also: [`marginalize`](@ref).
"""
function sample(process::AbstractGaussMarkovProcess, times, N=1)
function sample(process::AbstractGaussMarkovProcess, times, N::Integer=1)
X = initial_distribution(process)
X = Gaussian(mean(X), Matrix(cov(X)))
s = rand(X, N)
Expand Down
Loading