Skip to content

feat: custom load (dsl) implement support#1213

Open
RickyYCheng wants to merge 1 commit into
nathanhoad:mainfrom
RickyYCheng:dev_dsl_load
Open

feat: custom load (dsl) implement support#1213
RickyYCheng wants to merge 1 commit into
nathanhoad:mainfrom
RickyYCheng:dev_dsl_load

Conversation

@RickyYCheng
Copy link
Copy Markdown

@RickyYCheng RickyYCheng commented May 23, 2026

#1209 highlights a security risk associated with the load/Load DSL function in *.dialogue files.

This PR introduces a Callable field, allowing users to configure the behavior of the load/Load functions. Corresponding tests have been added.

This PR only adds the configuration and does not modify the language server or code hints for *.dialogue files.

For example, this slice of code will be prevent if the load function was set to Callable(). No compile time warnings.

DialogueManager.dialogue_dsl_load = Callable()
$> debug(load("res://icon.svg"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant