Skip to content

Conversation

@fxjwind
Copy link

@fxjwind fxjwind commented Sep 4, 2013

  • fix wrong comment
  • improve the logic of sort-slots #359

@patricioe
Copy link

Is this solving the problem of no allocating evenly based on currently used slots?

In my case, rebalance command keeps on sending the worker to the same machine instead of the one of all free slots.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test data here actually violates the worker number constraints, you specified the worker number to 4 for topology1, but here it is assigned 6 different workers.

@fxjwind
Copy link
Author

fxjwind commented Oct 8, 2013

@xumingming , thanks for your comments, have already updated

@fxjwind
Copy link
Author

fxjwind commented Oct 8, 2013

@patricioe , you are right, this fix will choose supervisor with less workers(used-slots) preferentially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants