This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Added next slide number as a second parameter to the start() callback.#565
Open
kitgrose wants to merge 1 commit intonathansearles:SlidesJS-3from
Open
Added next slide number as a second parameter to the start() callback.#565kitgrose wants to merge 1 commit intonathansearles:SlidesJS-3from
kitgrose wants to merge 1 commit intonathansearles:SlidesJS-3from
Conversation
This allows other JavaScript to react to the content of the next slide before the animation has been performed (no matter how the user navigates around). Compiled the JS with CoffeeScript v1.1.2 and minified it with UglifyJS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows other JavaScript to react to the content of the next slide before the animation has been performed (no matter how the user navigates around).
By making it a second parameter this should not affect any other existing code.
Compiled the JS with CoffeeScript and minified it with UglifyJS (had to fix an indentation issue on line 519 of the
jquery.slides.coffeefile for CoffeeScript to compile it, but that was only incidental to this change).