This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Add "zoom images" feature#578
Open
charlesbaynham wants to merge 9 commits intonathansearles:SlidesJS-3from
Open
Add "zoom images" feature#578charlesbaynham wants to merge 9 commits intonathansearles:SlidesJS-3from
charlesbaynham wants to merge 9 commits intonathansearles:SlidesJS-3from
Conversation
added 8 commits
July 4, 2014 15:19
Line 519 was indented with tabs instead of spaces which caused coffee-script to fail.
Adding the “zoom = true” option will cause images to be zoomed & centred in the slider div so that they fill the slider without being distorted
If zoom is set to true, children imgs of div slides will also be expanded in the same way that imgs are
Zooming actually only needs to be done once since the slider preserves its aspect ratio
Allow the slider to be resized using javascript after it’s loaded.
Author
There was a problem hiding this comment.
This was from a previous commit. On mac, it was stopping coffee-script from compiling.
…on future load events in case the image src changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option "zoom" to allow users to set their images to resize until they fill the slider. Images will be resized and centered, but not distorted.