Feat/refresh token#5
Open
yutianqin wants to merge 10 commits into
Open
Conversation
Drop status/get-ingress targets and add create/delete for the jupyterhub-metrics-secret alongside the existing jupyterhub-secret.
Extend page.html instead of error.html, add a logout link, and update the admin contact email.
…ample Replace the retired NDP Endpoint Data Streaming & Data Staging Examples profile with the new NDP-EP/SciDx ALL-IN-ONE Demo image.
pexpect>=4.9 works around a git-clone issue in the extra install step; the Pelican CLI is fetched into ~/.local/bin for users working with Pelican federations.
Sets --ServerApp.allow_origin=* so the JupyterLab websocket connection isn't rejected when the hub sits behind an external nginx that doesn't forward the Origin header the way JupyterHub expects.
spawner.access_token is only set by auth_state_hook when a server actually starts, so it can be stale by the time options_form runs. Read fresh auth_state and attempt a refresh via check_refresh_token_keycloak regardless of auth_refresh_age, and show a 'session expired' notice in the entity dropdown instead of silently rendering an empty list when the refresh fails. Also surface PVC fetch failures from get_user_pvcs instead of swallowing them as [].
…s form Same fix as the helm-generic chart: spawner.access_token is only set by auth_state_hook when a server actually starts, so it can be stale by the time options_form runs. Read fresh auth_state and attempt a refresh via check_refresh_token_keycloak instead of using the possibly-stale token directly.
Contributor
|
Looks good to me! thanks Yutian! |
SidT12
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NRP and Generic
Generic:
NDP-EP/SciDx ALL-IN-ONE Demoserver template profileNDP Endpoint Data Streaming & Data Staging Examplesserver template profile@saleemalharir1 @jessdtate this PR includes recent changes I made for ndp-jhub
@SidT12 Please review at your convenience, thanks