Skip to content

Pin third-party actions to commit SHAs#7

Merged
ahosgood merged 8 commits into
mainfrom
pinact/pin-actions
Apr 22, 2026
Merged

Pin third-party actions to commit SHAs#7
ahosgood merged 8 commits into
mainfrom
pinact/pin-actions

Conversation

@kurtismash

Copy link
Copy Markdown
Member

This PR pins third-party GitHub Actions to full commit SHAs for supply-chain security.

This has been done automatically by pinact. When reviewing please confirm that the SHAs are correct, zizmor will alert if not.

As a maintainer, please merge this PR once approved.

@ahosgood

Copy link
Copy Markdown
Member

@kurtismash I also want to update all actions/checkout@v4 to actions/checkout@v6 because support is going to be dropped for v4 in a few months. How possible is that to do?

Comment thread .github/workflows/deploy-docs.yml Outdated
@wiz-2986343e2e

wiz-2986343e2e Bot commented Apr 22, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Pull Request Developer Guidance

If the link to the Wiz scan details doesn't work, please ensure you are using the right role in Wiz and that the repository is assigned to the correct project within our Wiz Terraform. Or, you can ask for help in #tna-cloud-security on Slack.

Comment thread .github/workflows/cd.yml
- name: Generate version tag
id: version-tag
uses: nationalarchives/ds-docker-actions/.github/actions/get-version-tag@main
uses: nationalarchives/ds-docker-actions/.github/actions/get-version-tag@main # zizmor: ignore[unpinned-uses] Owned by The National Archives

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium IaC Finding

Workflow should not use branch-pinned third-party actions
on resource jobs.build.steps[1].uses

More Details
This rule checks that GitHub workflow does not use branch-pinned third-party actions. This rule fails when a workflow contains steps that use third-party actions referenced by branch names (like @main, @master, @develop) instead of specific commit SHAs. Using branch-pinned actions creates a significant security risk as branches are mutable references, allowing the action maintainer to modify the code that will be executed in future workflow runs without changing the referencing workflow file. This is particularly dangerous as it could lead to supply chain attacks where malicious code is introduced after your workflow is created. To prevent this risk, pin third-party actions to specific commit SHAs.

Expected

Workflow job 'build' step[1] should pin third-party action to a commit SHA or version tag rather than a branch

Found

Workflow job 'build' step[1] uses branch-pinned third-party action: 'nationalarchives/ds-docker-actions/.github/actions/get-version-tag@main'

Security Frameworks: wf-id-1, wf-id-175


Rule ID: 88c6171f-260e-4e65-929a-3dab36a97930


To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason

If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).


To get more details on how to remediate this issue using AI, reply to this conversation with #wiz remediate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#wiz_ignore Owned by The National Archives

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finding has been successfully ignored for these checks.

If you'd like to ignore this finding in all future scans, you can add a matching exception in the .wiz file.
Learn more

@ahosgood ahosgood merged commit 6b14c40 into main Apr 22, 2026
10 checks passed
@ahosgood ahosgood deleted the pinact/pin-actions branch April 22, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants