Skip to content

packaging issue: sideEffects false is incorrect #27

Description

@NathanWalker

The package declares sideEffects: false but that's not accurate because index-common has a critical top-level side-effect call to overrideSpanAndFormattedString(...) which monkey-patches TextBase.prototype to use NSTextUtils' min/max-line-height semantics.

This adversely affects bundlers that honor this flag.

The fix can publish with sideEffects: true.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions