fix: use Jekyll collections in search.json - #45
Merged
Conversation
Jekyll requires collection directories under collections_dir to be prefixed with underscore (e.g., content/_locksounds/ not content/locksounds/). Without the prefix, Jekyll treats the markdown files as regular pages instead of collection documents, causing site[page.collection_name] to return empty and category pages to show no items. - Renamed all 5 collection dirs: _locksounds, _lightshows, _boombox, _wraps, _hornsounds - Updated scripts/build.ts to reference underscore-prefixed dirs - Updated PR templates with correct directory paths Co-Authored-By: Paperclip <noreply@paperclip.ing>
search.json was iterating site.pages which doesn't include Jekyll collection documents. Now iterates site[cat] for each content category and uses item.collection for category detection, matching the fix applied to the category template in da46884. Co-Authored-By: Paperclip <noreply@paperclip.ing>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site.pagesiteration withsite[cat]to correctly discover Jekyll collection documents (lightshows, locksounds, boombox, wraps, hornsounds)item.collectionfor category detection instead of path-prefix matchingTest plan
search.jsoncontains all 5 collection categoriesFixes NAT-102
🤖 Generated with Claude Code