fix(build): explicitly include @types/node in tsconfig (unblocks TypeScript 6) - #78
Merged
Merged
Conversation
…Script 6) scripts/build.ts + validate.ts rely on Node globals (fs, path, process, console, Buffer, __dirname). TypeScript <=5 auto-included all @types/* packages, so this worked implicitly; TypeScript 6.0 no longer does, so ts-node failed to type-check both scripts (TS2591/2584/2304 'cannot find name ...' + TS7006 implicit-any on the now-uncontextualized callbacks), breaking the validate + build CI checks (see Renovate PR #77). Declaring types:[node] fixes it and is harmless on TS 5 (Node types are auto-included there anyway). Verified: validate + build pass with 0 TS errors on both TS 5.9.3 and TS 6.0.3. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate PR #77 (typescript 5→6) fails
validate+buildbecause TS 6.0 stopped auto-including@types/*, so the Node globals in the build scripts no longer resolve.\"types\": [\"node\"]totsconfig.json.npm run validate+npm run buildpass with 0 TS errors on both TS 5.9.3 and TS 6.0.3.With this on
main, #77 goes green once Renovate rebases it (or hit the rebase checkbox). Harmless on the current TS 5.🤖 Generated with Claude Code