Skip to content

Improve validation logic#33

Merged
mtmk merged 9 commits intomainfrom
add-more-validation
Apr 2, 2025
Merged

Improve validation logic#33
mtmk merged 9 commits intomainfrom
add-more-validation

Conversation

@mtmk
Copy link
Member

@mtmk mtmk commented Apr 1, 2025

Added more model validation and fixed DecodeClaims<T>() to decode any claims model including auth requests used in callouts.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 99.15254% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (4a9a63c) to head (1d48d17).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/NATS.Jwt/ModelValidationExtensions.cs 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   76.88%   79.73%   +2.84%     
==========================================
  Files          48       49       +1     
  Lines         809      893      +84     
  Branches       63       81      +18     
==========================================
+ Hits          622      712      +90     
+ Misses        162      155       -7     
- Partials       25       26       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtmk mtmk marked this pull request as ready for review April 2, 2025 17:50
@mtmk mtmk requested a review from aricart April 2, 2025 17:50
aricart
aricart previously approved these changes Apr 2, 2025
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but should make sure that anything you generate will be valid in the Go library... Also on the doc for the lib, it should say that the Go library performs many validation that this library doesn't.

@mtmk
Copy link
Member Author

mtmk commented Apr 2, 2025

This looks good to me, but should make sure that anything you generate will be valid in the Go library... Also on the doc for the lib, it should say that the Go library performs many validation that this library doesn't.

good point. created #34 to track that

@mtmk mtmk merged commit f5bda82 into main Apr 2, 2025
8 checks passed
@mtmk mtmk deleted the add-more-validation branch April 2, 2025 19:34
mtmk added a commit that referenced this pull request Apr 2, 2025
* Improve validation logic (#33)
@mtmk mtmk mentioned this pull request Apr 2, 2025
mtmk added a commit that referenced this pull request Apr 2, 2025
* Improve validation logic (#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants