Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the NATS.Jwt project file by making the inclusion of the System.Text.Json package conditional to the netstandard2.0 target framework.
- Moves the System.Text.Json package reference into a conditional ItemGroup for netstandard2.0
- Removes the unconditional reference from the global ItemGroup
Comments suppressed due to low confidence (1)
src/NATS.Jwt/NATS.Jwt.csproj:26
- Moving the System.Text.Json package reference into a conditional ItemGroup ensures it’s only included for netstandard2.0. Please confirm that no other target frameworks require a direct dependency on System.Text.Json.
<PackageReference Include="System.Text.Json" Version="8.0.5"/>
Member
STJ is included in new .NET SDKs already. the reason we added this was due to a CVE at the time. Since SDKs are patched by now we can assume users should've installed the fixed SDKs by now. |
Merged
mtmk
added a commit
that referenced
this pull request
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40