fix: allow import of same service subject from different accounts#243
Merged
aricart merged 1 commit intonats-io:mainfrom Feb 27, 2026
Merged
Conversation
thobiaskarlsson
force-pushed
the
feat/import-same-service-from-diff-accounts
branch
2 times, most recently
from
0098b9f to
f92bb52
Compare
nats-server already allows importing the same (service) subject from different account, while the jwt does not. This becomes an issue when you, for instance, source JetStreams from different accounts and need to import service `$JS.FC.>` from both. Before, this could be solved by importing e.g. `$JS.FC.STREAM_FROM_ACC_X.>` and `$JS.FC.STREAM_FROM_ACC_Y.>`, but this requires globally unique stream names. If those streams are both called `ORDERS` then you wouldn't be able to source both. Issue: nats-io/nats-server#7326 Related: nats-io/nats-server#6704 Related: nats-io/nats-server#6547 Related: nats-io/nats-server#6431 Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
thobiaskarlsson
force-pushed
the
feat/import-same-service-from-diff-accounts
branch
from
f92bb52 to
f80aa4c
Compare
Member
|
@thobiaskarlsson thank you for the PR. - will merge as soon as the failure for coveralls is resolved. |
Pull Request Test Coverage Report for Build 22295578499Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nats-server already allows importing the same (service) subject from different account, while the jwt does not. This becomes an issue when you, for instance, source JetStreams from different accounts and need to import service
$JS.FC.>from both. Before, this could be solved by importing e.g.$JS.FC.STREAM_FROM_ACC_X.>and$JS.FC.STREAM_FROM_ACC_Y.>, but this requires globally unique stream names. If those streams are both calledORDERSthen you wouldn't be able to source both.Issue: nats-io/nats-server#7326
Related: nats-io/nats-server#6704
Related: nats-io/nats-server#6547
Related: nats-io/nats-server#6431
Signed-off-by: Thobias Karlsson thobias.karlsson@gmail.com