Clarify configChecksumAnnotation behavior for non-reloadable params#1148
Open
jtnats wants to merge 1 commit intonats-io:mainfrom
Open
Clarify configChecksumAnnotation behavior for non-reloadable params#1148jtnats wants to merge 1 commit intonats-io:mainfrom
jtnats wants to merge 1 commit intonats-io:mainfrom
Conversation
|
Claude Code is working… I'll analyze this and get back to you. |
wallyqs
approved these changes
Mar 27, 2026
Member
wallyqs
left a comment
wallyqs
left a comment
There was a problem hiding this comment.
lgtm, maybe file a separate server issue that those fields are not reloadable and put
in the comment
wallyqs
reviewed
Mar 27, 2026
jtnats
force-pushed
the
docs/clarify-config-checksum-annotation
branch
from
94ad6b3 to
3e6c5f4
Compare
Author
|
I added a link to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Clarify configChecksumAnnotation behavior for non-reloadable params
Summary
configChecksumAnnotationcomment in values.yaml to warn that non-reloadable parameters (e.g.max_mem,max_file) are silently ignored when the reloader sends SIGHUPconfigChecksumAnnotation: truewhen using non-reloadable parameters so that a rolling restart applies themMotivation
With the default
configChecksumAnnotation: false, the reloader signalsSIGHUPon config changes. For non-reloadable parameters, the server rejects the reload and the new values never take effect but there is also no visible error to the user. This has been a source of confusion.