[ADDED] MQTT: allow custom timeout for JS API calls

[zlymeda]

There was a hard-coded timeout of 4s for making JS API calls (mqttJSAPITimeout).

Added an MQTT config option to configure this timeout.

Partially fixes #6191

I think the proper fix would require sending an error to the mqtt client that we could not create a subscription. But this helps to at least bump the limit.

Signed-off-by: Ondrej Belusky [email protected]

[zlymeda]

the original mqttJSAPITimeout was 4 seconds. however calling it with mqttJSAStreamNames had timeout of 5 seconds.
so I picked the large and used 5 seconds as a default timeout

[kozlovic]

I was going to ask to leave the default timeout to 4sec and keep the timeout as a parameter so that we would pass jsa.timeout most of time except for that specific situations that occur during a transfer of sessions (which is only when upgrading from a certain version to the other). But I guess making the default now 5sec should be fine. Alternatively, we set it back to 4sec and users that would upgrade from an older release where the session transfer session would occur and the 4sec would be too small, then they could explicitly configure to higher value (at least for the upgrade process).

I don't have strong opinion either way, so I think that is fine. The changes requested are around testing. Thanks!

[kozlovic]

Would rather have the new "negative" test along with the others, before the "positive" tests. Otherwise, LGTM.

[kozlovic]

LGTM

[neilalexander]

LGTM, thanks!