make rtt measurement duration configurable #7550
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Issue also discussed in How are NATS routez/connz rtt measured |
Author
|
For obvious reasons does RTT not update more often than |
Author
|
@neilalexander do I need to create an issue or something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics are based on the rtt measurement. The server PING is only sent if the connection has been without messages (including client PINGs) for the
ping_interval(server set).The
DEFAULT_RTT_MEASUREMENT_INTERVALis an hour meaning that metrics on a frequently used connection are only update with that interval.Troubleshooting when metrics are coarse can be difficult.
The suggested change allows servers to be configured to amend that.
Signed-off-by: Jonatan [email protected]