[FIXED] Missing leaf connect advisory for solicited connections

[MauriceVanVeen]

Resolves #7998

Signed-off-by: Maurice van Veen github@mauricevanveen.com

[synadia-claude-reviewer]

Claude finished @MauriceVanVeen's task in 1m 33s —— View job

---

PR Review: Missing leaf connect advisory for solicited connections

• Read CLAUDE.md for repo guidelines
• Examine PR diff
• Read relevant source context in leafnode.go
• Analyze test coverage
• Post review

---

Verdict: LGTM

The fix is correct, minimal, and well-tested.

Root Cause

For hub-side (accepted) leaf connections, accountConnectEvent is already fired via isClientAuthorized in auth.go:398 (which runs for inbound LEAF connections during auth). For spoke-side (solicited) connections, the connection is initiated outbound and doesn't go through isClientAuthorized, so accountConnectEvent was never called — causing the missing advisory.

The single-line addition in leafNodeFinishConnectProcess (which is only reachable for solicited/spoke connections — the accepting side returns early at leafnode.go:1504 when !didSolicit) correctly closes this gap without risk of double-firing.

Test

TestLeafNodeSpokeConnectAdvisory covers the scenario well: it validates both the DISCONNECT advisory (already working) and the CONNECT advisory (the bug) across a hub shutdown/restart cycle for the USER account leaf, confirming the fix works on reconnect too.

No issues found.

[neilalexander]

LGTM