[FIXED] Handling of reading of initial INFO protocol
#959
+137
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported that there was an issue in `natsSock_ReadLine()` which we use to read the initial `INFO` protocol. It is true that if reading the `INFO` would stop at the `\r`, just before the `\n`, then this function would not have detected the end of the protocl and would have waited for more data, which would have likely resulted in a timeout trying to connect. So although possible, it is very unlikely that the read just ends one byte short, but regardless, this has now been fixed. The existing test has been made "real" with use of socket and not just read from prexisting buffer. Resolves #958 Signed-off-by: Ivan Kozlovic <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
+ Coverage 70.24% 70.27% +0.02%
==========================================
Files 48 48
Lines 17357 17359 +2
Branches 3563 3563
==========================================
+ Hits 12193 12199 +6
+ Misses 1735 1731 -4
Partials 3429 3429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kozlovic
commented
Jan 7, 2026
Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that there was an issue in
natsSock_ReadLine()which we use to read the initialINFOprotocol. It is true that if reading theINFOwould stop at the\r, just before the\n, then this function would not have detected the end of the protocl and would have waited for more data, which would have likely resulted in a timeout trying to connect.So although possible, it is very unlikely that the read just ends one byte short, but regardless, this has now been fixed. The existing test has been made "real" with use of socket and not just read from prexisting buffer.
Resolves #958
Signed-off-by: Ivan Kozlovic [email protected]