fix: Memory Leak when create PullConsumer#2027
Merged
piotrpio merged 3 commits intonats-io:mainfrom Mar 3, 2026
Merged
Conversation
Signed-off-by: txuna <b7712983@naver.com>
txuna
force-pushed
the
fix/memory-leak
branch
from
be7a8bc to
29c3c43
Compare
piotrpio
reviewed
Mar 2, 2026
piotrpio
approved these changes
Mar 3, 2026
Collaborator
piotrpio
left a comment
piotrpio
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Memory Leak when create PullConsumer. So, add RemoveStatusListener in Consumer
Additional explanation
When create Consumer, allocate sub.connStatusChanged
But not delete map when Delete Consumer!