Conversation
When a NATS server rejects a WebSocket connection (e.g., due to an expired JWT), it sends a -ERR protocol message followed by a WebSocket close frame. If both frames arrive in the same TCP read, the websocketReader.Read() method would process the close frame and immediately return io.EOF, discarding the -ERR data that had already been buffered in the pending list. This caused nats.Connect to return a generic EOF error instead of the proper authentication error (ErrAuthorization, ErrAuthExpired, etc.), making it difficult for users to diagnose connection failures. The fix defers the close frame's io.EOF when there is already pending data, storing it in a new closeErr field. The pending data is returned first, and the deferred error is returned on the subsequent Read() call. Signed-off-by: Waldemar Quevedo <wally@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a NATS server rejects a WebSocket connection (e.g., due to an expired JWT), it sends a
-ERRprotocol message followed by a WebSocket close frame. If both frames arrive in the same TCP read, thewebsocketReader.Read()method would process the close frame and immediately returnio.EOF, discarding the-ERRdata that had already been buffered in the pending list.This caused
nats.Connectto return a generic EOF error instead of the proper authentication error (ErrAuthorization,ErrAuthExpired, etc.), making it difficult for users to diagnose connection failures.The fix defers the close frame's
io.EOFwhen there is already pending data, storing it in a newcloseErrfield. The pending data is returned first, and the deferred error is returned on the subsequent Read() call.