[FIXED] Panic in DecodeHeadersMsg on status tokens shorter than 3 characters#2101
Open
nikitha-m wants to merge 1 commit into
Open
[FIXED] Panic in DecodeHeadersMsg on status tokens shorter than 3 characters#2101nikitha-m wants to merge 1 commit into
nikitha-m wants to merge 1 commit into
Conversation
…racters Signed-off-by: Nikitha Mohithe <nikithamohite@Nikithas-MacBook-Air.local> Signed-off-by: Nikitha Mohithe <nikithamohithe@gmail.com> Signed-off-by: Nikitha Mohithe <mohitenikki2002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: DecodeHeadersMsg panics with "slice bounds out of range" when the inline status token (e.g.
NATS/1.0 5) is shorter than 3 characters. The guardlen(status) != statusLenwas meant to detect a trailing description but also matched short tokens, then attemptedstatus[3:]on a 0-2 byte string.Fix: Change the condition to
len(status) < statusLenand returnErrBadHeaderMsgfor malformed status tokens. Uselen(status) > statusLenfor the description split.Resolves #2100
Signed-off-by: Nikitha Mohithe mohitenikki2002@gmail.com