Main for server v2.11 #1239
Merged
Main for server v2.11 #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consumer Priority Group Overflow * Tests for Overflow plus Simplification Fetch * Tests for Overflow Simplification Iterate and Consume * use consumer-groups branch in build
scottf
commented
Oct 15, 2024
| @@ -680,6 +717,7 @@ public Builder(ConsumerConfiguration cc) { | |||
| this.maxBatch = cc.maxBatch; | |||
| this.maxBytes = cc.maxBytes; | |||
| this.numReplicas = cc.numReplicas; | |||
| this.pauseUntil = cc.pauseUntil; | |||
There was a problem hiding this comment.
This missing was a bug unrelated to 2.11
scottf
commented
Oct 15, 2024
| @@ -34,7 +33,7 @@ class NatsFetchConsumer extends NatsMessageConsumerBase implements FetchConsumer | |||
| { | |||
| super(cachedConsumerInfo); | |||
|
|
|||
| isNoWait = fetchConsumeOptions.isNoWait(); | |||
| boolean isNoWait = fetchConsumeOptions.isNoWait(); | |||
There was a problem hiding this comment.
not needed in the object, local is fine
# Conflicts: # src/main/java/io/nats/client/api/MessageBatchGetRequest.java
…sageGetRequest) back in
Replace net.i2p.crypto with BouncyCastle
# Conflicts: # src/main/java/io/nats/client/BaseConsumeOptions.java # src/test/java/io/nats/client/api/StreamConfigurationTests.java # src/test/java/io/nats/client/impl/JetStreamManagementTests.java
# Conflicts: # src/main/java/io/nats/client/BaseConsumeOptions.java
Main 2 11 merge safe
scottf
commented
Mar 20, 2025
| @@ -13,7 +13,7 @@ plugins { | |||
| id 'signing' | |||
| } | |||
|
|
|||
| def jarVersion = "2.20.7" | |||
| def jarVersion = "2.21.0" | |||
There was a problem hiding this comment.
Functionality requires a minor version
scottf
commented
Mar 20, 2025
| protected final boolean raiseStatusWarnings; | ||
|
|
||
| @SuppressWarnings("rawtypes") // Don't need the type of the builder to get its vars | ||
| protected BaseConsumeOptions(Builder b) { |
There was a problem hiding this comment.
I figured out the correct way to do this
scottf
commented
Mar 20, 2025
| @SuppressWarnings("rawtypes") // Don't need the type of the builder to get its vars | ||
| protected BaseConsumeOptions(Builder b) { | ||
| protected BaseConsumeOptions(Builder<?, ?> b) { | ||
| // Message / bytes is part of base and is calculated |
There was a problem hiding this comment.
This isn't 2.11 specific, but I had just made changes in this area, then realized I had better changes uncommitted, so put them here.
scottf
commented
Mar 20, 2025
| private FetchConsumeOptions(Builder b) { | ||
| super(b); | ||
| this.noWait = b.noWait; |
There was a problem hiding this comment.
Not 2.11, again part of missed commit improvements after 2.10.26 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer priority and overflow