Per Message TTL Support for 2.11 #1295
Conversation
| this.expectedLastSeq = b.expectedLastSeq; | ||
| this.expectedLastSubSeq = b.expectedLastSubSeq; | ||
| this.msgId = b.msgId; | ||
| this.msgTtlSeconds = b.msgTtlSeconds; |
There was a problem hiding this comment.
since private I can change. simplified constructor to take builder like most other places
| @@ -33,7 +33,7 @@ public enum AckPolicy { | |||
| */ | |||
| Explicit("explicit"); | |||
|
|
|||
| private String policy; | |||
| private final String policy; | |||
There was a problem hiding this comment.
I happened to be here and the IDE yelled at me, so I fixed it.
| .firstSequence(readLong(v, FIRST_SEQ, 1)) | ||
| .allowMessageTtl(readBoolean(v, ALLOW_MSG_TTL)) | ||
| .subjectDeleteMarkerTtl(readNanos(v, SUBJECT_DELETE_MARKER_TTL)) | ||
| .build(); |
There was a problem hiding this comment.
no sure why I didn't use the chain method before. This wasn't a necessary change.
| public Builder subjectDeleteMarkerTtl(Duration subjectDeleteMarkerTtl) { | ||
| this.subjectDeleteMarkerTtl = subjectDeleteMarkerTtl; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Coded, then commented out, then back in.
| @@ -198,6 +198,7 @@ private Headers mergePublishOptions(Headers headers, PublishOptions opts) { | |||
| merged = mergeString(merged, EXPECTED_LAST_MSG_ID_HDR, opts.getExpectedLastMsgId()); | |||
| merged = mergeString(merged, EXPECTED_STREAM_HDR, opts.getExpectedStream()); | |||
| merged = mergeString(merged, MSG_ID_HDR, opts.getMessageId()); | |||
| merged = mergeNum(merged, MSG_TTL_HDR, opts.getMsgTtlSeconds()); | |||
There was a problem hiding this comment.
mergeNum will add the header if the value is > -1
| assertEquals("MaxAge", mi.getHeaders().getFirst(NATS_MARKER_REASON_HDR)); | ||
| assertEquals("50s", mi.getHeaders().getFirst(MSG_TTL_HDR)); | ||
| }); | ||
| } |
There was a problem hiding this comment.
tests copied directly from the go client
| public void run(Options.Builder builder, InServerTest inServerTest) throws Exception { | ||
| run(builder, null, inServerTest); | ||
| } | ||
|
|
There was a problem hiding this comment.
just some extra testing scaffolding
| * @param msgTtlSeconds the ttl in seconds | ||
| * @return The Builder | ||
| */ | ||
| public Builder msgTtlSeconds(int msgTtlSeconds) { |
There was a problem hiding this comment.
Nats-TTL also supports the string "never", to indicate the message will never be removed, even if it would otherwise expire due to the stream's MaxAge.
No description provided.