Make the return type of update_stream match with create_stream#1380
Open
rauno56 wants to merge 2 commits intonats-io:mainfrom
Open
Make the return type of update_stream match with create_stream#1380rauno56 wants to merge 2 commits intonats-io:mainfrom
update_stream match with create_stream#1380rauno56 wants to merge 2 commits intonats-io:mainfrom
Conversation
3e3bb7c to
8e5c5dd
Compare
Author
|
Any feedback on this, @Jarema? |
Member
|
I will get back to this near the end of the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the return type of
update_streamonContextto match withcreate_stream. I can see how in the most common usecase, one would want to start using the updated stream immediately after - this change would save the network call of getting the stream after the update.Infois still reachable throughcached_info().PS. That's a breaking change. If you prefer to avoid it, I can rename it to
get_or_update_streamthat would matchget_or_create_streamas well, but leaveupdate_streamuntouched.