Use new start method for retry start in nats-server crate#1603
Conversation
Signed-off-by: Tomasz Pietrek <tomasz@synadia.com>
|
Claude finished @Jarema's task in 53s —— View job PR Review
Change summary: Single line in Assessment: No issues found. The rename is correct and aligns with the The change is confined entirely to |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cae99c6b2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| let retry_strategy = tokio_retry::strategy::ExponentialBackoff::from_millis(500).take(3); | ||
| let mut stream = tokio_retry::Retry::spawn(retry_strategy, || { | ||
| let mut stream = tokio_retry::Retry::start(retry_strategy, || { |
There was a problem hiding this comment.
Raise the tokio-retry version before calling start
This call only compiles when Cargo resolves tokio-retry to the new release that added Retry::start; the crate still declares tokio-retry = "0.3.0" in nats-server/Cargo.toml, and 0.3.0/0.3.1 expose Retry::spawn instead. Any build using an existing lockfile or minimal-version resolution within the allowed 0.3.x range will fail here, so the dependency lower bound needs to be bumped along with this API change.
Useful? React with 👍 / 👎.
Signed-off-by: Tomasz Pietrek tomasz@synadia.com