fix account info deser failure on servers with tiered jetstream#1604
Open
xanderio wants to merge 1 commit into
Open
fix account info deser failure on servers with tiered jetstream#1604xanderio wants to merge 1 commit into
xanderio wants to merge 1 commit into
Conversation
The `api` field doesn't exist in the tier response object, this was confirmed by looking at the relavent go code [1]. nats-servers without tiered jetstream, it seems that this is only included if JWT based authentiction is in use, don't include the `tier` object and field at all. That allows clients to connect without running into the deser error. [1]: https://github.com/nats-io/nats-server/blob/717c7d17efb387b6db31ed3a0301d1250b073207/server/jetstream.go#L77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
apifield doesn't exist in the tier response object, this was confirmed by looking at the relavent go code 1.nats-servers without tiered jetstream, it seems that this is only included if JWT based authentiction is in use, don't include the
tierobject and field at all. That allows clients to connect without running into the deser error.