Skip to content

Add Seal and Open methods for xkeys encryption#7

Merged
mtmk merged 10 commits intomainfrom
xkeys-seal-open
Mar 30, 2025
Merged

Add Seal and Open methods for xkeys encryption#7
mtmk merged 10 commits intomainfrom
xkeys-seal-open

Conversation

@mtmk
Copy link
Copy Markdown
Member

@mtmk mtmk commented Mar 21, 2025

@mtmk mtmk requested a review from aricart March 22, 2025 00:09
seal64,

// generated using nkeys Go library:
"eGt2MchZLvgdJ5IKV4ZD/pAHnpwGMw2D2j7eA/vjRBhZzWmQAvbTzMTu8M1aevP4Gg==",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link
Copy Markdown
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the other test which you possibly did is to encrypt on your side, and decrypt in the Go client with xkeys generated by the Go client.

@mtmk
Copy link
Copy Markdown
Member Author

mtmk commented Mar 22, 2025

LGTM - the other test which you possibly did is to encrypt on your side, and decrypt in the Go client with xkeys generated by the Go client.

@aricart added a simple .NET + Go test to check both ways

@mtmk mtmk merged commit f5169a5 into main Mar 30, 2025
6 checks passed
@mtmk mtmk deleted the xkeys-seal-open branch March 30, 2025 14:21
mtmk added a commit that referenced this pull request Apr 2, 2025
* Add key validation (#8)
* Add Seal and Open methods for xkeys encryption (#7)
@mtmk mtmk mentioned this pull request Apr 2, 2025
mtmk added a commit that referenced this pull request Apr 2, 2025
* Add key validation (#8)
* Add Seal and Open methods for xkeys encryption (#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Add xKey Encryption/Decryption Support

2 participants