-
Notifications
You must be signed in to change notification settings - Fork 150
Export account resource metrics and configuration #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds three new metrics that collects configured reserved memory and storage along with how many bytes are currently used.
e6f55c3
to
27340d1
Compare
works as expected in my local R1 setup:
|
we don't seem to have any tests around the account metrics. not sure @MattiasAng are you feeling generous enough to write a test case or perhaps we can leave that to another PR. wdyt @piotrpio? |
Hi! I was actually about to submit a PR for these metrics but then found this PR. :) I adjusted my code so now my PR only includes an updated test matching the metrics names of this PR. The test is in this PR #351 should work. Sorry if this is not the correct way of doing this |
great! thanks @dg-plejd. more tests are always welcome. I'll have a look at the PR. |
Thanks @dg-plejd, I was about to say that I'm a bit short on time. |
This one blocks #351 (adding test cases) so we would really appreciate that someone can review and move it on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for the reminder @plejd-sebman and apologies for the delay. Please feel free to update #351 after merge cc @dg-plejd |
Adds four new metrics that collects configured reserved memory and storage along with how many bytes are currently used of each.
This will allow users to monitor resource consumption based on set maximum.
I've decided to name the configured reserved metrics as
max
to align with configuration file rather than what the API response attribute is named (reserved).Example response: