Add ip label to all gatewayz metrics #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
reviewed
Mar 25, 2025
There was a problem hiding this comment.
thanks @wjordan looks good to me in general i have a couple of questions:
afaics one should be able to figure out which gateway from the remote_gateway_name label. do we really need the IP? since we need to also consider growth in the metric payload as well as prometheus database.
| @@ -97,62 +97,62 @@ func newGateway(system, endpoint, gwType string) *gateway { | |||
| configured: prometheus.NewDesc( | |||
| prometheus.BuildFQName(system, endpoint, gwType+"_configured"), | |||
| "configured", | |||
| []string{"gateway_name", "cid", "remote_gateway_name", "server_id"}, | |||
| []string{"gateway_name", "cid", "ip", "remote_gateway_name", "server_id"}, | |||
There was a problem hiding this comment.
should we name it remote_ip since it seems to be the IP of the remote gateway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
ipfield is in theoutbound_gateways.[name].connectionobject in the/gatewayzresponse, helps identify the remote IP address used for the gateway connection and we've found that having this label in the metric is useful for monitoring and debugging gateway connections.