Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Chapter 4 Edits #75

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Chapter 4 Edits #75

merged 3 commits into from
Feb 21, 2020

Conversation

shiffman
Copy link
Member

Just a start so far. . .

@shiffman
Copy link
Member Author

Noting a couple open questions as I pause at section 4.5.

  1. Once I add origin this code becomes a little awkward, might reconsider.
  addParticle() {
    this.particles.push(new Particle(this.origin.x, this.origin.y));
  }
  1. applyForce() gravity should maybe end up in the ParticleSystem class, but maybe I just address this later in the chapter.

Code updates: nature-of-code/noc-examples-p5.js-archived#93

@shiffman
Copy link
Member Author

@joeyklee also if you look at my changes so far I decided to go with splice() over filter() but keeping a reference to filter(). I should also probably explain that there is a for in loop and a forEach() higher-order function somewhere.

@shiffman
Copy link
Member Author

Just under 7 months later I have returned to editing this chapter! Merging in the final changes and noting small things remaining in separate issues.

@shiffman shiffman merged commit ae4970f into source Feb 21, 2020
@shiffman shiffman changed the title [WIP] Chapter 4 Edits Chapter 4 Edits Feb 21, 2020
@joeyklee
Copy link
Collaborator

Hooray! Excellent!

@joeyklee joeyklee deleted the chapter4-systems-shiffman-edits branch February 21, 2020 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants