Skip to content

Minor fixes#31

Open
NikDrummond wants to merge 2 commits intomasterfrom
hemibrainr_localBranch
Open

Minor fixes#31
NikDrummond wants to merge 2 commits intomasterfrom
hemibrainr_localBranch

Conversation

@NikDrummond
Copy link
Copy Markdown
Contributor

No description provided.

@jefferis
Copy link
Copy Markdown
Contributor

Hi @NikDrummond, I was going to merge this as it all seems fine, but if you have a moment, maybe you could explain why the two changes were made? Best, Greg.

@NikDrummond
Copy link
Copy Markdown
Contributor Author

Hi Greg,

Bug fixes were as follows:
1) The predicted soma coordinates under some conditions were incorrectly transformed, so plotted in the wrong place.
2) Due to differences in where hemibrinar::plot3d_somas() thinks somas are, and those recorded in the gsheet, again somas in some conditions were being plotted in the wrong place.

The other general fix was due to the 'unfixed' column being argued to be unintuitive, so is now 'fixed' with True for a soma deemed as correct.

I would maybe hold off on merging this branch however, as there is a 'for_Imaan' parameter Alex and I talked about changing to be more globally applicable, and there are some edits I wish to make regarding optional large scale error correcting, if this is wanted at a later date.

@jefferis
Copy link
Copy Markdown
Contributor

OK thanks for the clarification @NikDrummond. I'll wait. @alexanderbates can merge when ready. Best, Greg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants