Fixes for CRAN + R-4.5.1 #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jefferis
commented
Aug 8, 2025
jefferis
commented
- explicit links to all remote packages now required in docs
- fixes because SWC files are now excluded from tarballs
- fixes for recent igraph deprecations
* also remove unnecessary executable permissions
* workaround for new behaviour in R 4.5.1 associated with this change wch/r-source@7bc89c8
* we want to exclude swc.txt files since they are neither swc nor nml
* as.directed, as.undirected, graph * decided to wrap them so we don't have to fast forward igraph dependency to >=2.1.0 from >=1.0 * had to remove the explicit function imports (because we don't know which to import) * note that I also had to make an example conditional based on the installed version for the same reasons * see also igraph/rigraph#1513
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
=========================================
Coverage ? 76.94%
=========================================
Files ? 48
Lines ? 6082
Branches ? 0
=========================================
Hits ? 4680
Misses ? 1402
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* there is a problem with Clang 18 on ubuntu and the register keyword. * this will need to be fixed soon but since it is really beyond the scope of this repo I am going to work around for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.