Use the memoised version of neuprint_fetch in a couple more places#105
Open
Use the memoised version of neuprint_fetch in a couple more places#105
Conversation
Contributor
|
Hi @romainFr this might require a little more thought.
On which point I seem to remember seeing so we might be able to condition the memoisation on the last-mod or uuid fields for the dataset. Perhaps you could get some confirmation from Steve as to whether these change with any change to the database? |
Collaborator
Author
|
I think what we also want is I didn't think about the memory limitations though. Maybe in what I committed only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.